Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Allow disabling of query logs #225

Closed
kshcherban opened this issue Jun 25, 2021 · 7 comments · Fixed by #248
Closed

[Feature request]: Allow disabling of query logs #225

kshcherban opened this issue Jun 25, 2021 · 7 comments · Fixed by #248
Assignees
Labels
🔨 enhancement New feature or request
Milestone

Comments

@kshcherban
Copy link
Contributor

kshcherban commented Jun 25, 2021

This is a feature request.
Would be nice to have query log completely disabled for better privacy.

Query log can be enabled by default as it is now but should be optionally disabled with a change to a configuration.

@kshcherban kshcherban changed the title Enable query logs disabling [Feature request]: Allow disabling of query logs Jun 25, 2021
@0xERR0R
Copy link
Owner

0xERR0R commented Jun 25, 2021

You can disable the query log, just remove queryLog section from the config file

@kshcherban
Copy link
Contributor Author

kshcherban commented Jun 25, 2021

Thank you, wasn't clear from documentation to me. Closing.

@kshcherban
Copy link
Contributor Author

In example configuration there's no query log section, but docker logs all queries. Do I miss something? I use version 0.14.

@0xERR0R
Copy link
Owner

0xERR0R commented Jun 25, 2021

Ok, I think, there is a misunderstanding: If queryLog is enabled, blocky logs each request with response in a CSV file. If queryLog is disabled, blocky logs only to stdout. The only way to disable it is to increase the log Level (to warn for example)

@kshcherban
Copy link
Contributor Author

kshcherban commented Jun 25, 2021 via email

@0xERR0R
Copy link
Owner

0xERR0R commented Jun 25, 2021

ok, I know what you mean. I think, it would make sense not to log each request with detailed information on info log level (which is default). I would leave detailed logging (is useful for debugging or investigation of dns problems), but maybe use some kind of "special" logger which is disabled by default or just on debug level.

@0xERR0R
Copy link
Owner

0xERR0R commented Aug 23, 2021

Solution:
new configuration property: "logPrivacy", default false. If set to "true", it will obfuscate request and response information (replace every alphanumeric character with *)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants