Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change format for duration #263

Closed
0xERR0R opened this issue Sep 6, 2021 · 0 comments · Fixed by #277
Closed

Change format for duration #263

0xERR0R opened this issue Sep 6, 2021 · 0 comments · Fixed by #277
Assignees
@0xERR0R
Labels
🔨 enhancement New feature or request
Milestone
v0.16

Comments

@0xERR0R
Copy link
Owner

0xERR0R commented Sep 6, 2021

All duration properties in config.yaml like:

  • blocking.refreshPeriod
  • caching.minTime
  • caching.maxTime
  • caching.prefetchExpires
  • ...

should use the duration format from Golang (https://pkg.go.dev/time#ParseDuration). To avoid breaking changes, a value without unit should be accepted and used as before (typically with second as unit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xERR0R 0xERR0R

Labels
🔨 enhancement New feature or request
Projects
None yet
Milestone
v0.16
Development

Successfully merging a pull request may close this issue.

Change configuration format for duration (#263) 0xERR0R/blocky
1 participant
@0xERR0R