Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ginkgolinter to golangci #1235

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Nov 12, 2023

Added ginkgolinter to golangci config to disable some rules automatically in tests if ginkgo is imported.

@kwitsch kwitsch added the 🔨 enhancement New feature or request label Nov 12, 2023
@kwitsch kwitsch enabled auto-merge (squash) November 12, 2023 16:19
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@ThinkChaos ThinkChaos changed the title Feature/ginkgolinter feat: add ginkgolinter to golangci Nov 12, 2023
.golangci.yml Show resolved Hide resolved
@kwitsch kwitsch merged commit 7615584 into 0xERR0R:main Nov 12, 2023
3 checks passed
@kwitsch kwitsch deleted the feature/ginkgolinter branch November 12, 2023 18:40
@0xERR0R 0xERR0R added this to the v0.23 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants