-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring server.go #1277
Merged
Merged
Refactoring server.go #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # config/config_test.go # resolver/strict_resolver_test.go
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
==========================================
- Coverage 93.87% 93.75% -0.13%
==========================================
Files 75 77 +2
Lines 6023 6083 +60
==========================================
+ Hits 5654 5703 +49
- Misses 284 292 +8
- Partials 85 88 +3 ☔ View full report in Codecov by Sentry. |
ThinkChaos
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
context.Background
fromOnRequest
in favor of ctxStop
usesShutdownContext
DoGetRequest
usesNewRequestWithContext
Part of #1264