Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrapDNS not used for upstream DNS resolution (#242) #246

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Aug 21, 2021

fixes #242

@0xERR0R 0xERR0R added this to the 0.16 milestone Aug 21, 2021
@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #246 (e7f3e2b) into development (7ea4b54) will decrease coverage by 0.06%.
The diff coverage is 45.23%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #246      +/-   ##
===============================================
- Coverage        94.11%   94.04%   -0.07%     
===============================================
  Files               27       28       +1     
  Lines             2072     2084      +12     
===============================================
+ Hits              1950     1960      +10     
- Misses              91       94       +3     
+ Partials            31       30       -1     
Impacted Files Coverage Δ
util/bootstrap.go 0.00% <0.00%> (ø)
cmd/root.go 61.53% <50.00%> (ø)
config/config.go 83.67% <66.66%> (-1.59%) ⬇️
resolver/upstream_resolver.go 88.11% <85.71%> (-0.18%) ⬇️
cmd/serve.go 100.00% <100.00%> (+31.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea4b54...e7f3e2b. Read the comment docs.

@0xERR0R 0xERR0R merged commit 850baf0 into development Aug 21, 2021
@0xERR0R 0xERR0R deleted the bootstrapdns branch August 23, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootstrapDNS not used for upstream DNS resolution
1 participant