Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make retry for list download configurable (#308) #338

Merged
merged 6 commits into from
Nov 14, 2021

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Nov 13, 2021

New configuration options:

  • blocking.downloadAttempts
  • blocking.downloadCooldown

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #338 (0f33753) into development (e882fa0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #338   +/-   ##
============================================
  Coverage        96.11%   96.12%           
============================================
  Files               30       30           
  Lines             2216     2221    +5     
============================================
+ Hits              2130     2135    +5     
  Misses              56       56           
  Partials            30       30           
Impacted Files Coverage Δ
config/config.go 91.48% <ø> (ø)
lists/list_cache.go 94.38% <100.00%> (+0.06%) ⬆️
resolver/blocking_resolver.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e882fa0...0f33753. Read the comment docs.

@kwitsch kwitsch changed the title Make retry for list download configurable (#308) Make retry for list download configurable ( #308 ) Nov 13, 2021
@kwitsch kwitsch changed the title Make retry for list download configurable ( #308 ) Make retry for list download configurable (#308) Nov 13, 2021
@0xERR0R
Copy link
Owner

0xERR0R commented Nov 14, 2021

This is cool! Thx and 🤝

@0xERR0R
Copy link
Owner

0xERR0R commented Nov 14, 2021

closes #308

@0xERR0R 0xERR0R added this to the 0.17 milestone Nov 14, 2021
@0xERR0R 0xERR0R merged commit 2f79086 into 0xERR0R:development Nov 14, 2021
@0xERR0R 0xERR0R linked an issue Nov 14, 2021 that may be closed by this pull request
@kwitsch kwitsch deleted the #308 branch November 15, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make retry for list download configurable
2 participants