Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring custom DNS TTL #370

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

ThinkChaos
Copy link
Collaborator

I changed the tests to use a random but common TTL on each run. Maybe you'd prefer a separate test for the TTL explicitly.
Also, I haven't updated the docs.

@ThinkChaos ThinkChaos force-pushed the feat/config-customdns-ttl branch from 5f9ddae to b071e2b Compare December 14, 2021 17:58
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #370 (25a088f) into development (9fcb11e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #370   +/-   ##
============================================
  Coverage        96.17%   96.17%           
============================================
  Files               30       30           
  Lines             2250     2251    +1     
============================================
+ Hits              2164     2165    +1     
  Misses              56       56           
  Partials            30       30           
Impacted Files Coverage Δ
config/config.go 91.48% <ø> (ø)
resolver/custom_dns_resolver.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcb11e...25a088f. Read the comment docs.

@0xERR0R
Copy link
Owner

0xERR0R commented Dec 15, 2021

Thanks for your work! It looks good. Do you want to add a description to configuration.md and docs/config.yml? If not, it is ok, I can do it.

@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Dec 15, 2021
@0xERR0R 0xERR0R added this to the 0.18 milestone Dec 15, 2021
@ThinkChaos ThinkChaos force-pushed the feat/config-customdns-ttl branch from b071e2b to 25a088f Compare December 16, 2021 00:36
@ThinkChaos
Copy link
Collaborator Author

I added the docs!

@0xERR0R 0xERR0R merged commit cbcd09c into 0xERR0R:development Dec 16, 2021
@ThinkChaos ThinkChaos deleted the feat/config-customdns-ttl branch January 24, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants