Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failed_download_count metric #395

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

FileGo
Copy link
Collaborator

@FileGo FileGo commented Jan 3, 2022

This implements #309 . Adds blocky_failed_download_count Prometheus metric, which increments the counter for every failed attempt to download a blocking list.

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #395 (ac64aae) into development (9259c5c) will increase coverage by 1.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #395      +/-   ##
===============================================
+ Coverage        93.89%   95.17%   +1.27%     
===============================================
  Files               31       31              
  Lines             2426     2427       +1     
===============================================
+ Hits              2278     2310      +32     
+ Misses             111       80      -31     
  Partials            37       37              
Impacted Files Coverage Δ
lists/list_cache.go 94.50% <100.00%> (+0.03%) ⬆️
resolver/caching_resolver.go 95.27% <0.00%> (-3.15%) ⬇️
redis/redis.go 89.06% <0.00%> (+27.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9259c5c...ac64aae. Read the comment docs.

@0xERR0R 0xERR0R linked an issue Jan 4, 2022 that may be closed by this pull request
@0xERR0R 0xERR0R added this to the 0.18 milestone Jan 4, 2022
@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Jan 4, 2022
@0xERR0R 0xERR0R merged commit 926f06c into 0xERR0R:development Jan 4, 2022
@FileGo FileGo deleted the failed_download_count branch May 17, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus metric "failed_download_count" for failed downloads
2 participants