-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow changes #857
Workflow changes #857
Conversation
[pull] development from 0xERR0R:development
[pull] development from 0xERR0R:development
Development pull
Codecov ReportBase: 93.02% // Head: 93.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## development #857 +/- ##
===============================================
+ Coverage 93.02% 93.14% +0.12%
===============================================
Files 42 42
Lines 4944 4944
===============================================
+ Hits 4599 4605 +6
+ Misses 273 268 -5
+ Partials 72 71 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The flakiness of e2e unit tests could be reduced by reducing the Eventually polling times from default 10ms to 2ms. There seems to be a problem with with the upstart of test containers that occured randomly(?). During my test i could reproduce the errors more often if polling times where higher (100-500ms). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
Reducing the polling time from 10ms to 2ms will increase the load and to be honest, I don't understand why it reduces the test flakyness 🤷♂️ . IMHO the poling time should have no effect, only the duration is relevant. |
I know that in theory but reality showed otherwise. 🫤 Could it be that the test containers keep restarting if expected to be stopped? |
Goal of this PR is to combat flakyness & streamline workflows.
Content: