Move the golden images test to golang (kubevirt#2427)

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
0xFelix · Jul 10, 2023 · 2e339b9 · 2e339b9
1 parent 1bbdfa3
commit 2e339b9
Show file tree

Hide file tree

Showing 32 changed files with 15,657 additions and 207 deletions.
diff --git a/hack/check_golden_images.sh b/hack/check_golden_images.sh
diff --git a/hack/run-tests.sh b/hack/run-tests.sh
@@ -42,9 +42,6 @@ ${KUBECTL_BINARY} get hco -n "${INSTALLED_NAMESPACE}" kubevirt-hyperconverged -o
 # wait a bit to make sure the VMs are deleted
 sleep 60
 
-# Check golden images
-KUBECTL_BINARY=${KUBECTL_BINARY} ./hack/check_golden_images.sh
-
 # Check TLS profile on the webhook
 KUBECTL_BINARY=${KUBECTL_BINARY} ./hack/check_tlsprofile.sh
 

diff --git a/hack/upgrade-test-index-image.sh b/hack/upgrade-test-index-image.sh
@@ -331,9 +331,6 @@ else
     echo "TTO reference removed from .status.relatedObjects"
 fi
 
-Msg "check golden images"
-KUBECTL_BINARY=${CMD} INSTALLED_NAMESPACE=${HCO_NAMESPACE} ./hack/check_golden_images.sh
-
 Msg "check virtio-win image is in configmap"
 VIRTIOWIN_IMAGE_CSV=$(${CMD} get ${CSV} -n ${HCO_NAMESPACE} \
   -o jsonpath='{.spec.install.spec.deployments[?(@.name=="hco-operator")].spec.template.spec.containers[0].env[?(@.name=="VIRTIOWIN_CONTAINER")].value}')

diff --git a/hack/upgrade-test-operator-sdk.sh b/hack/upgrade-test-operator-sdk.sh
@@ -289,9 +289,6 @@ else
     echo "TTO reference removed from .status.relatedObjects"
 fi
 
-Msg "check golden images"
-KUBECTL_BINARY=${CMD} INSTALLED_NAMESPACE=${HCO_NAMESPACE} ./hack/check_golden_images.sh
-
 Msg "check virtio-win image is in configmap"
 VIRTIOWIN_IMAGE_CSV=$(${CMD} get ${CSV} -n ${HCO_NAMESPACE} \
   -o jsonpath='{.spec.install.spec.deployments[?(@.name=="hco-operator")].spec.template.spec.containers[0].env[?(@.name=="VIRTIOWIN_CONTAINER")].value}')

diff --git a/tests/func-tests/config.go b/tests/func-tests/config.go
@@ -5,7 +5,7 @@ import (
 	"os"
 	"sync"
 
-	"gopkg.in/yaml.v2"
+	"gopkg.in/yaml.v3"
 )
 
 const (
@@ -37,9 +37,15 @@ type DashboardTestConfig struct {
 	TestItems []DashboardTestItem `yaml:"testItems,omitempty"`
 }
 
+type DataImportCronConfig struct {
+	ExpectedDataImportCrons []string `yaml:"expectedDataImportCrons,omitempty"`
+	Namespace               string   `yaml:"namespace,omitempty"`
+}
+
 type TestConfig struct {
-	QuickStart QuickStartTestConfig `yaml:"quickStart,omitempty"`
-	Dashboard  DashboardTestConfig  `yaml:"dashboard,omitempty"`
+	QuickStart     QuickStartTestConfig `yaml:"quickStart,omitempty"`
+	Dashboard      DashboardTestConfig  `yaml:"dashboard,omitempty"`
+	DataImportCron DataImportCronConfig `yaml:"dataImportCron,omitempty"`
 }
 
 func init() {
@@ -56,19 +62,19 @@ func GetConfig() *TestConfig {
 }
 
 func loadConfig(fileName string) *TestConfig {
-	config := TestConfig{}
+	cfg := TestConfig{}
 
 	if fileName != "" {
 		file, err := os.Open(fileName)
 		if err != nil {
 			panic(err)
 		}
 		dec := yaml.NewDecoder(file)
-		err = dec.Decode(&config)
+		err = dec.Decode(&cfg)
 		if err != nil {
 			panic(err)
 		}
 	}
 
-	return &config
+	return &cfg
 }
diff --git a/tests/func-tests/dict_test.go b/tests/func-tests/dict_test.go