Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Search not working properly #412

Closed
bitsky6 opened this issue Jun 6, 2024 · 2 comments
Closed

Browser Search not working properly #412

bitsky6 opened this issue Jun 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bitsky6
Copy link

bitsky6 commented Jun 6, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Manage Sites -> Sites Lists'
  2. Click on 'any of the configs'
  3. When you have it open in advanced mode and try to search the content of a larger config that needs scrolling as it can't fit in one page you press CTRL + F as usually to search for a word.
  4. It will only match what is on the current page, as soon as I try to scroll down the match disappears and wont see all of them.
  5. Would be preferable maybe the search to be inside the editor on the top so can actually search inside the config for specific words.

Expected behavior
I expect when I open in advanced mode the config and I want to search for the word for example "socket" it will match all words inside the config with simply pressing CTRL + F so can find and replace in case need multiple matches.

Screenshots
On this page I search for the word socket and gives me 6 matches.
But if I actually scroll down inside the config are 2 more socket words which are not matched unless scrolled down.
This can be dangerous in case you think have found all the changes you need but actually you missed some.
image

image

Info (please complete the following information):

  • Server OS: Docker
  • Server Arch: [e.g. x86, ]
  • Nginx UI Version: 2.0.0-beta.24 (135)
  • Your Browser: [e.g. Chrome, Firefox]
@bitsky6 bitsky6 added the bug Something isn't working label Jun 6, 2024
@0xJacky
Copy link
Owner

0xJacky commented Jun 7, 2024

Hi @bitsky6, I just load the search box module of ace editor for it, and you will be able to use the search feature by pressing Ctrl+F (Command+F for macOS) in next beta version of Nginx UI.

image

@bitsky6
Copy link
Author

bitsky6 commented Jun 7, 2024

Thanks for the feedback will wait on the new one having this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants