Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rig-lancedb): rag embedding filtering #104

Merged
merged 9 commits into from
Nov 15, 2024
Merged

fix(rig-lancedb): rag embedding filtering #104

merged 9 commits into from
Nov 15, 2024

Conversation

marieaurore123
Copy link
Contributor

No description provided.

@mateobelanger mateobelanger changed the title Bug(lancedb)/rag embedding filtering Bug(lancedb): rag embedding filtering Nov 14, 2024
@mateobelanger mateobelanger changed the title Bug(lancedb): rag embedding filtering bug(lancedb): rag embedding filtering Nov 14, 2024
@mateobelanger mateobelanger changed the title bug(lancedb): rag embedding filtering fix(lancedb): rag embedding filtering Nov 14, 2024
cvauclair
cvauclair requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@cvauclair cvauclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! But there are a couple things to change, mostly for logging

rig-core/src/providers/anthropic/completion.rs Outdated Show resolved Hide resolved
rig-core/src/providers/cohere.rs Outdated Show resolved Hide resolved
rig-core/src/providers/gemini/completion.rs Outdated Show resolved Hide resolved
rig-core/src/providers/openai.rs Outdated Show resolved Hide resolved
rig-core/src/providers/perplexity.rs Outdated Show resolved Hide resolved
rig-lancedb/src/utils/mod.rs Outdated Show resolved Hide resolved
@cvauclair cvauclair changed the title fix(lancedb): rag embedding filtering fix(rig-lancedb): rag embedding filtering Nov 14, 2024
@marieaurore123 marieaurore123 merged commit f4452fc into main Nov 15, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Closed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvauclair cvauclair cvauclair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marieaurore123 @cvauclair