feat: migrateTo #67
feat: migrateTo #67
Conversation
src/PolygonMigration.sol
Outdated
| @@ -51,6 +51,14 @@ contract PolygonMigration is Ownable2StepUpgradeable, IPolygonMigration { | |||
| polygon.safeTransfer(msg.sender, amount); | |||
| } | |||
|
|
|||
| /// @inheritdoc IPolygonMigration | |||
| function migrateTo(address recipient, uint256 amount) external { | |||
| emit Migrated(msg.sender, amount); | |||
There was a problem hiding this comment.
Just wondering whether or not we should follow the same standard used by Unmigrated where we do have both the origin account and recipient as part of the event
event Unmigrated(address indexed account, address indexed recipient, uint256 amount);
We should probably create a new event following the same pattern for MigrationTo in order to capture "msg.sender vs. recipient information" to differentiate from a normal migrate function.
wdyt?
|
| /// @param amount the amount of MATIC that was migrated | ||
| event Migrated(address indexed account, uint256 amount); | ||
| event Migrated(address indexed account, address recipient, uint256 amount); |
There was a problem hiding this comment.
Hi, thanks. I'd suggest we confirm if this event signature "change" is breaking any known relevant event listeners to agree on the best way to mitigate its impact (i.e. sometimes we do recommend to create new events instead).
Add
migrateTofunction to PolygonMigration contract.