Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert logical condition in WaitUntil functions #1123

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Invert logical condition in WaitUntil functions #1123

merged 3 commits into from
Jan 16, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Jan 14, 2023 •
edited
Loading

Description

This PR inverts logical condition for WaitUntil function, since previous implementation expected false logical condition as WaitUntil function's exit criteria. However it is not as intuitive and practical as it should be, since we need to think about exit criteria and then negate it.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal mentioned this pull request Jan 14, 2023
Closed
11 tasks
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-366-e-2-e-framework-wait-until-function-invert-logic branch January 14, 2023 08:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
@Stefan-Ethernal Stefan-Ethernal restored the EVM-366-e-2-e-framework-wait-until-function-invert-logic branch January 14, 2023 08:11
@Stefan-Ethernal Stefan-Ethernal self-assigned this Jan 14, 2023
@Stefan-Ethernal Stefan-Ethernal added bug fix Functionality that fixes a bug feature New update to Polygon Edge and removed feature New update to Polygon Edge bug fix Functionality that fixes a bug labels Jan 14, 2023
@ferranbt ferranbt removed their request for review January 16, 2023 07:52
vcastellm
vcastellm approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩

@Stefan-Ethernal Stefan-Ethernal merged commit 3c6e048 into feature/v3-parity Jan 16, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-366-e-2-e-framework-wait-until-function-invert-logic branch January 16, 2023 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@b00ris b00ris b00ris approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@begmaroman begmaroman Awaiting requested review from begmaroman

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stefan-Ethernal @vcastellm @b00ris @goran-ethernal