Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stake flag to manifest command #1137

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Jan 17, 2023

Description

This PR introduces stake flag to the manifest command. This flag enables specifying genesis validators' stake. Prior to this PR, validators' balances were used as stake amount staked.

If a stake flag is not provided, then the stake defaults to 1M tokens (the same as with the pre-mine balance).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Introduced stake field as part of InitialValidatorSet in the genesis specification.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this Jan 17, 2023
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@3f29527). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             feature/v3-parity    #1137   +/-   ##
====================================================
  Coverage                     ?   54.57%           
====================================================
  Files                        ?      173           
  Lines                        ?    23070           
  Branches                     ?        0           
====================================================
  Hits                         ?    12590           
  Misses                       ?     9489           
  Partials                     ?      991           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩

@Stefan-Ethernal Stefan-Ethernal added the don't merge Please don't merge this functionality temporarily label Jan 25, 2023
Base automatically changed from feature/v3-parity to develop February 6, 2023 07:53
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-374-decouple-stake-from-balance-definition branch from d502167 to 367bff0 Compare March 6, 2023 07:51
@Stefan-Ethernal Stefan-Ethernal removed the don't merge Please don't merge this functionality temporarily label Mar 8, 2023
@Nemanja0x
Copy link
Contributor

Nemanja0x commented Mar 8, 2023

  1. I would like stake to be a mandatory field for each validator (maybe to require to be greater than zero)
  2. Open question is if the stake flag is independent from balance flag. If it is, then the total amount of tokens that a genesis validator owns is stake + balance.

These are requirement questions and it would be good to discuss them before merging this PR.

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-374-decouple-stake-from-balance-definition branch 2 times, most recently from 606009d to 60fc599 Compare March 14, 2023 07:11
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-374-decouple-stake-from-balance-definition branch from 60fc599 to 4a64b06 Compare March 21, 2023 08:33
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-374-decouple-stake-from-balance-definition branch from ced6f0b to c2ba954 Compare March 22, 2023 11:32
@Stefan-Ethernal Stefan-Ethernal merged commit 983ef2d into develop Mar 22, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-374-decouple-stake-from-balance-definition branch March 22, 2023 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
@Stefan-Ethernal Stefan-Ethernal added the breaking change Functionality that contains breaking changes label Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Functionality that contains breaking changes feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants