-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM-440-Using-UTC-time #1304
EVM-440-Using-UTC-time #1304
Conversation
0d265f6
to
d130139
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find it necessary to create a package out of the stdlib for wrapping the same calls to the stdlib, it creates unnecessary roundtrip for the reader, the value provided is very limited and it's very prone to be skipped in new code.
I vote for just using stdlib
@vcastellm Those were my initial thoughts as well, but I've gone with Evgeny's proposal on that task, to have it wrapped for easier usage. I am down whatever we find more comfortable. |
d130139
to
2a34996
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2a34996
to
8c9e598
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Using local validators’ time zones may result in chain fork. So through this PR, we are using the
UTC
time throughout the code.PR also introduces a lint rule that checks if
time.Now
variations are being used in code without calling theUTC
function as well.Changes include
Checklist
Testing