Fix proposer logging for HasQuorum function #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stana-miric
changed the title
Stefan-Ethernal
approved these changes
Mar 17, 2023
Nemanja0x
approved these changes
Mar 20, 2023
b00ris
approved these changes
Mar 22, 2023
vcastellm
deleted the
EVM-531-fix-proposer-logging-for-has-quorum-function
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HasQuorum fn, if the view(height or round) from the message does not match the view from the proposer calculator, that will be logged as debug instead of warning and false should be returned. This is valid case because node can run the sequence for the height lower than the height from calculator since the calculator is updated on block insertion (which can come from the syncer as well and thus the proposer calculator can have different height that message).
Changes include
Checklist
Testing