Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify state transactions function in FSM #1312

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

As stateTransactions function returns only single transaction, which is the one for bridge commitment registration, it is renamed and it's signature is changed, so it returns only single instance instead of slice.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Mar 19, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team March 19, 2023 09:34
@Stefan-Ethernal Stefan-Ethernal self-assigned this Mar 19, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/simplify-state-transactions-fn branch from 46ac45d to d9737ce Compare March 19, 2023 09:35
consensus/polybft/fsm.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a small comment, LGTM 💯

@Stefan-Ethernal Stefan-Ethernal merged commit 308fe5b into develop Mar 22, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/simplify-state-transactions-fn branch March 22, 2023 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants