Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract storage from blockchain construction #1318

Conversation

tuommaki
Copy link
Contributor

@tuommaki tuommaki commented Mar 21, 2023

Description

This change separates storage instance construction from blockchain construction. This is necessary for having ability to use custom storage implementation as a backing storage for the blockchain.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

blockchain.NewBlockchain() takes now storage.Storage instance as a parameter, instead of dataDir describing path to storage (or empty string for in-memory one).

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

This change separates storage instance construction from blockchain
construction. This is necessary for having ability to use custom storage
implementation as a backing storage for the blockchain.
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@vcastellm vcastellm requested a review from a team March 21, 2023 15:12
@vcastellm vcastellm merged commit 985ddb5 into 0xPolygon:develop Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants