Some SyncPeerStatus messages were not published #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stana-miric
requested review from
vcastellm,
igorcrevar,
Nemanja0x,
Stefan-Ethernal and
goran-ethernal
stana-miric
force-pushed
the
EVM-530-two-blocks-are-possibly-written-simultaneously
branch
from
7c1be6c
to
73541bf
Compare
igorcrevar
approved these changes
Mar 22, 2023
Nemanja0x
approved these changes
Mar 22, 2023
goran-ethernal
approved these changes
Mar 22, 2023
Stefan-Ethernal
approved these changes
Mar 22, 2023
Stefan-Ethernal
deleted the
EVM-530-two-blocks-are-possibly-written-simultaneously
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem fixed in this PR is related to publishing SyncPeerStatus. Some messages were not published because of the bug in startNewBlockProcess fn of syncPeerClient where each time after the notification is dispatched on block insertions the new channel is created for the same syncPeerClient subscription. This could be noticed on non validator nodes since they are not producing block but instead receiving them upon SyncPeerStatus is published (when syncer's newStatusCh is set). On those nodes as reproduced on the test system as well, blocks were not arriving one by one.
-The main fix is in syncer/client.go
-Unit test is written and for that purpose, mocked subscriber is adjusted to look more like real subscriber in order to be able to test this scenario (it does not affect other test, the previous version was more simplified because it was sufficient for existing tests).
-blockchain.go is changed because source of the block is added to the log since we have that data and it can be useful
Changes include
Checklist
Testing