Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy NFT contracts #1322

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Deploy NFT contracts #1322

merged 3 commits into from
Apr 4, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Mar 22, 2023 •
edited

Description

This PR introduces NFT predicates and mock NFT tokens to the Edge.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Mar 22, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Mar 22, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-537-deploy-contracts branch 2 times, most recently from aacefdf to 1e222cc Compare March 23, 2023 09:18
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review March 23, 2023 09:48
@Stefan-Ethernal
Copy link
Collaborator Author

Stefan-Ethernal commented Mar 23, 2023 •
edited

It is expected that TestE2E_Consensus_Validator_Unstake fails, because of recent changes on ChildValidatorSet smart contract. #1325 addresses this problem.

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-537-deploy-contracts branch 4 times, most recently from e203684 to 13fd8c1 Compare March 24, 2023 10:40
@Stefan-Ethernal Stefan-Ethernal changed the base branch from feature/erc721-erc1155-integration to develop March 24, 2023 10:43
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-537-deploy-contracts branch 2 times, most recently from 5bf49fc to 22b99d9 Compare March 29, 2023 11:32
@Stefan-Ethernal Stefan-Ethernal merged commit afee1c6 into develop Apr 4, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-537-deploy-contracts branch April 4, 2023 11:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stefan-Ethernal @vcastellm @goran-ethernal