Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage of localstack AWS SSM Parameter Store #1327

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Allow usage of localstack AWS SSM Parameter Store #1327

merged 2 commits into from
Apr 23, 2023

Conversation

Pirellik
Copy link
Contributor

@Pirellik Pirellik commented Mar 23, 2023 •
edited

Description

This PR adds a possibility to use Localstack instead of real AWS to create/read secrets using Parameter Store. It utilizes existing cli flag (--server-url) to instantiate proper aws config that targets localstack instance. If not provided it will target real AWS instead.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

I've tested it locally with Localstack instance.

@github-actions
Copy link

github-actions bot commented Mar 23, 2023 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Pirellik
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 23, 2023
@github-actions
@Pirellik has signed the CLA from Pull Request #1327
0b74471
vcastellm
vcastellm approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcastellm vcastellm requested a review from a team April 17, 2023 16:31
@Stefan-Ethernal Stefan-Ethernal merged commit de84d4f into 0xPolygon:develop Apr 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pirellik @vcastellm @Stefan-Ethernal