Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide hex encoded private key #1328

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Mar 23, 2023

Description

This PR changes rootchain init contracts and bridge transactions helper commands to rely on hex encoded private key, instead of secrets manager since it is more streamlined to provide private key that way (and the fact that these commands are going to be used only for one time deployment and testing purposes).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal self-assigned this Mar 23, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-552-rootchain-commands-provide-hex-encoded-private-key branch from 1ba60ac to ec4d6c9 Compare March 23, 2023 11:31
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Mar 23, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review March 23, 2023 14:44
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-552-rootchain-commands-provide-hex-encoded-private-key branch from d8b52d6 to a99cb80 Compare March 27, 2023 19:41
@Stefan-Ethernal Stefan-Ethernal merged commit 7a949d7 into develop Mar 29, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-552-rootchain-commands-provide-hex-encoded-private-key branch March 29, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants