-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add godox linter and resolve trivial TODO comments #1329
Merged
stana-miric
merged 2 commits into
develop
from
EVM-443-remove-tod-os-and-fixm-es-from-the-code
Mar 27, 2023
Merged
Add godox linter and resolve trivial TODO comments #1329
stana-miric
merged 2 commits into
develop
from
EVM-443-remove-tod-os-and-fixm-es-from-the-code
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stana-miric
requested review from
vcastellm,
igorcrevar,
Nemanja0x,
Stefan-Ethernal and
goran-ethernal
March 23, 2023 10:44
stana-miric
changed the title
Added: godox linter,tasks for unresolved TODOs
Add godox linter and resolve trievial TODO comments
Mar 23, 2023
stana-miric
force-pushed
the
EVM-443-remove-tod-os-and-fixm-es-from-the-code
branch
from
March 23, 2023 10:50
ced36e9
to
f7048d9
Compare
Stefan-Ethernal
changed the title
Add godox linter and resolve trievial TODO comments
Add godox linter and resolve trivial TODO comments
Mar 23, 2023
Stefan-Ethernal
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, nice job!
stana-miric
force-pushed
the
EVM-443-remove-tod-os-and-fixm-es-from-the-code
branch
from
March 24, 2023 08:48
e721ab4
to
17429bb
Compare
vcastellm
approved these changes
Mar 24, 2023
goran-ethernal
approved these changes
Mar 27, 2023
Nemanja0x
approved these changes
Mar 27, 2023
stana-miric
force-pushed
the
EVM-443-remove-tod-os-and-fixm-es-from-the-code
branch
from
March 27, 2023 10:55
17429bb
to
cf02fb4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Tasks created for unsresolved TODOs are: EVM-519, EVM-521, EVM-522, EVM-523, EVM-524, EVM-525, EVM-527, EVM-528, EVM-529, EVM-540, EVM-541, EVM-542
Changes include
Checklist
Testing
Additional comments
Note that ValidatorSetAddr and StateReceiverAddr are removed form PolyBFTConfig, since we have those addresses in the contracts package. As I discuss it with Stefan, it should not affect backward compatibility since they are not included in the blockchain