EVM-553: Enable generating of functions with same names in contracts api #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
requested review from
Stefan-Ethernal,
Nemanja0x,
igorcrevar and
vcastellm
and removed request for
Stefan-Ethernal
Stefan-Ethernal
approved these changes
Mar 23, 2023
goran-ethernal
deleted the
EVM-553-Handle-functions-with-same-name-in-bindings-gen
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a situation where 2 separate contracts have functions with same name. For example:
mintfunction inNativeERC20MintableandNativeERC20contracts.This PR now generates go stubs for contract functions, where their name is
NameOfFunction + ContractName + Fn(e.g.,InitializeNativeERC20MintableFnandMintRootERC20Fn).Changes include
Checklist
Testing