Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide correct property tests logs path #1335

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Provide correct property tests logs path #1335

merged 3 commits into from
Mar 27, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Mar 25, 2023 •
edited

Description

This PR fixes the provided property tests log path in the GH workflow.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Mar 25, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Mar 25, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/provide-correct-logs-dir-property-tests branch from 8a5b319 to 5121e1f Compare March 25, 2023 05:51
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/provide-correct-logs-dir-property-tests branch from 5121e1f to e8643f6 Compare March 25, 2023 06:23
@goran-ethernal goran-ethernal merged commit 83ffef6 into develop Mar 27, 2023
@goran-ethernal goran-ethernal deleted the fix/provide-correct-logs-dir-property-tests branch March 27, 2023 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@vcastellm vcastellm vcastellm approved these changes

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@b00ris b00ris Awaiting requested review from b00ris

@ferranbt ferranbt Awaiting requested review from ferranbt

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Stefan-Ethernal @vcastellm @Nemanja0x @goran-ethernal