Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eth_call override #1337

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Add eth_call override #1337

merged 4 commits into from
Apr 11, 2023

Conversation

ferranbt
Copy link
Contributor

Description

This PR implements the eth_call override server functionality. With the override enabled, the caller can change the state being used for the execution of the call. There are five parameters that can be changed (nonce, balance, code, full state or single state slots).

I have also updated ethgo with this PR to enable the e2e test as well.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@vcastellm vcastellm requested a review from a team March 31, 2023 09:16
igorcrevar
igorcrevar reviewed Mar 31, 2023
View reviewed changes
state/executor.go Outdated Show resolved Hide resolved
igorcrevar
igorcrevar approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@igorcrevar igorcrevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, just a small objection to an unnecessary condition

Stefan-Ethernal
Stefan-Ethernal approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from nitpicks

state/executor.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/jsonrpc_test.go Outdated Show resolved Hide resolved
state/executor_test.go Show resolved Hide resolved
@vcastellm vcastellm self-assigned this Apr 3, 2023
vcastellm
vcastellm approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcastellm vcastellm merged commit 36772f4 into develop Apr 11, 2023
@vcastellm vcastellm deleted the feat-eth-call-state-override branch April 11, 2023 08:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ferranbt @vcastellm @igorcrevar @Stefan-Ethernal @goran-ethernal