Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for allowlist proxy #1338

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Add e2e test for allowlist proxy #1338

merged 1 commit into from
Apr 3, 2023

Conversation

ferranbt
Copy link
Contributor

Description

This PR completes the Allow list (#1306) e2e test with a new test to check that a contract could call an allow list to check the role of an account.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@vcastellm vcastellm self-assigned this Apr 3, 2023
@vcastellm vcastellm requested a review from a team April 3, 2023 14:59
@Nemanja0x Nemanja0x self-requested a review April 3, 2023 15:07
@vcastellm vcastellm merged commit 7911c43 into develop Apr 3, 2023
@vcastellm vcastellm deleted the e2e-allowlist-proxy branch April 3, 2023 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants