Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-533 Nightly slack notificatinos #1341

Merged
merged 16 commits into from
Apr 3, 2023
Merged

EVM-533 Nightly slack notificatinos #1341

merged 16 commits into from
Apr 3, 2023

Conversation

Nemanja0x
Copy link
Contributor

@Nemanja0x Nemanja0x commented Mar 28, 2023 •
edited

Add nightly build slack notifications:

  1. link to actions
  2. build details

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Nemanja0x Nemanja0x added the bug fix Functionality that fixes a bug label Mar 28, 2023
@Nemanja0x Nemanja0x force-pushed the build-yml-fix branch 2 times, most recently from df21fc8 to 39694be Compare March 28, 2023 11:57
@Nemanja0x Nemanja0x force-pushed the build-yml-fix branch 2 times, most recently from 9f982bc to 0af693f Compare March 28, 2023 14:24
@Nemanja0x Nemanja0x changed the title Fixes on yml files EVM-533 Nightly slack notificatinos Mar 28, 2023
@Nemanja0x Nemanja0x self-assigned this Mar 28, 2023
@Nemanja0x Nemanja0x added feature New update to Polygon Edge and removed bug fix Functionality that fixes a bug labels Mar 28, 2023
@Nemanja0x Nemanja0x force-pushed the build-yml-fix branch 2 times, most recently from bdb93b9 to 49184d5 Compare March 29, 2023 08:06
@Nemanja0x Nemanja0x marked this pull request as ready for review March 29, 2023 08:11
@igorcrevar igorcrevar force-pushed the build-yml-fix branch 6 times, most recently from fdf0fde to 30cf38a Compare April 1, 2023 16:46
vcastellm
vcastellm reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it a little bit more eye-catching?
image

@igorcrevar igorcrevar force-pushed the build-yml-fix branch 6 times, most recently from 1239df4 to 98668f0 Compare April 3, 2023 10:57
@igorcrevar
Copy link
Contributor

Can we make it a little bit more eye-catching? image

Screenshot from 2023-04-03 13-34-46

@igorcrevar igorcrevar force-pushed the build-yml-fix branch 2 times, most recently from 2cdd770 to 9747b57 Compare April 3, 2023 13:00
Stefan-Ethernal
Stefan-Ethernal approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Left some suggestions to consider.

.github/workflows/nightly.yml Outdated Show resolved Hide resolved
.github/workflows/nightly.yml Show resolved Hide resolved
vcastellm
vcastellm approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩

@igorcrevar igorcrevar merged commit 880c32f into develop Apr 3, 2023
@igorcrevar igorcrevar deleted the build-yml-fix branch April 3, 2023 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@stana-miric stana-miric Awaiting requested review from stana-miric

@igorcrevar igorcrevar Awaiting requested review from igorcrevar

Assignees

@Nemanja0x Nemanja0x

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Nemanja0x @igorcrevar @vcastellm @Stefan-Ethernal @goran-ethernal