Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor punctuation mistakes #1343

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Fix minor punctuation mistakes #1343

merged 1 commit into from
Mar 31, 2023

Conversation

SebastianSupreme
Copy link
Contributor

Description

Fixed minor punctuation mistakes in the docker README.

@SebastianSupreme
Copy link
Contributor Author

@vcastellm @stana-miric @igorcrevar Could one of you please approve this as well?

@vcastellm
Copy link
Contributor

@SebastianSupreme you should sign the CLA

@SebastianSupreme
Copy link
Contributor Author

@vcastellm @Stefan-Ethernal Could you merge this now, please?

@Stefan-Ethernal
Copy link
Collaborator

Stefan-Ethernal commented Mar 31, 2023 •
edited

@vcastellm @Stefan-Ethernal Could you merge this now, please?

As Victor already explained, you should sign CLA. You should add this comment:

I have read the CLA Document and I hereby sign the CLA

(#774 (comment)).

Do it and then we are good to merge I'd say.

@SebastianSupreme
Copy link
Contributor Author

@Stefan-Ethernal what is a CLA?

@Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal what is a CLA?

A contributor license agreement (https://yahoo.github.io/oss-guide/docs/resources/what-is-cla.html#:~:text=A%20Contributor%20License%20Agreement%20(CLA,to%20an%20open%20source%20project.). By default it is mandatory that each contributor signs it first time they contribute to this repository.

@SebastianSupreme
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Mar 31, 2023 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions bot added a commit that referenced this pull request Mar 31, 2023
@github-actions
@SebastianSupreme has signed the CLA from Pull Request #1343
b062a2a
@Stefan-Ethernal Stefan-Ethernal merged commit 0631dd4 into 0xPolygon:develop Mar 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SebastianSupreme @vcastellm @Stefan-Ethernal