ERC 721 tokens bridge integration #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
EVM-538-erc-721-integration
branch
2 times, most recently
from
087d09d
to
75dc621
Compare
Stefan-Ethernal
added
feature
|
|
goran-ethernal
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
LGTM
Suggestion for some future PRs, since we have similar tests for Deposit/Withdraw workflow for different tokens, we can maybe extract some stuff to separate functions (or merge these tests into one - as @Stefan-Ethernal mentioned, this is already being done, through a PR that will be created in the near future). The same goes to the deposit/withdraw commands, maybe we can extract some parts of code to some helper functions. Seems doable to me. Might be worth analyzing it further, so we don't have much repeating code.
vcastellm
reviewed
Apr 3, 2023
vcastellm
reviewed
Apr 3, 2023
Stefan-Ethernal
force-pushed
the
EVM-539-erc-1155-integration
branch
from
2efb94e
to
0c92fc9
Compare
Nemanja0x
approved these changes
Apr 4, 2023
Stefan-Ethernal
force-pushed
the
EVM-538-erc-721-integration
branch
from
47c73bb
to
e34be7d
Compare
vcastellm
approved these changes
Apr 4, 2023
Stefan-Ethernal
force-pushed
the
EVM-539-erc-1155-integration
branch
from
0c92fc9
to
f023eaf
Compare
Stefan-Ethernal
force-pushed
the
EVM-538-erc-721-integration
branch
from
e34be7d
to
52d8c43
Compare
Stefan-Ethernal
force-pushed
the
EVM-539-erc-1155-integration
branch
from
f023eaf
to
d5d7126
Compare
Stefan-Ethernal
force-pushed
the
EVM-538-erc-721-integration
branch
from
52d8c43
to
5da5aac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates predicate contracts for bridging ERC 721 tokens from a root to a child chain (and vice versa).
Changes include
Breaking changes
PR deploys a set of ERC 1155 bridge contracts to the genesis.
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it