Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions allow list #1349

Merged
merged 9 commits into from
Apr 4, 2023
Merged

Transactions allow list #1349

merged 9 commits into from
Apr 4, 2023

Conversation

vcastellm
Copy link
Contributor

@vcastellm vcastellm commented Mar 31, 2023 •
edited

Description

In this PR we introduce the allow list for transactions, allowing the network to setup an allow list for transaction execution. The transactions won't fail but will be reverted with an error message.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Sending manual transactions

@vcastellm vcastellm marked this pull request as ready for review April 1, 2023 07:39
@vcastellm vcastellm requested a review from a team April 1, 2023 07:39
@vcastellm vcastellm self-assigned this Apr 1, 2023
@vcastellm vcastellm added the feature New update to Polygon Edge label Apr 1, 2023
@vcastellm vcastellm changed the title Implement transactions allow list Transactions allow list Apr 3, 2023
goran-ethernal
goran-ethernal approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Stefan-Ethernal
Stefan-Ethernal approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good and leaving some comments to consider.

server/server.go Outdated Show resolved Hide resolved
contracts/system_addresses.go Show resolved Hide resolved
Stefan-Ethernal
Stefan-Ethernal reviewed Apr 4, 2023
View reviewed changes
chain/params.go Outdated Show resolved Hide resolved
@vcastellm vcastellm merged commit b48f781 into develop Apr 4, 2023
@vcastellm vcastellm deleted the EVM-565-allow-list-for-transaction-creation branch April 4, 2023 13:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcastellm @igorcrevar @Stefan-Ethernal @goran-ethernal