Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add receivers to sync state actions on sequence diagram #1358

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Add receivers to sync state actions on sequence diagram #1358

merged 1 commit into from
Apr 6, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Apr 4, 2023 •
edited

Description

This PR adds a bit of more information to the sequences diagram (e.g. receiver contract when syncState is being called).

Preview of diagrams is here:
https://github.com/0xPolygon/polygon-edge/blob/ed6966ff8da4b3bb3ad364008504fb8019d9a257/docs/bridge/sequences.md

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal changed the title Add receivers to sync state actions Add receivers to sync state actions on sequence diagram Apr 4, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 4, 2023
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Apr 4, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 4, 2023 10:37
@Nemanja0x Nemanja0x self-requested a review April 6, 2023 07:24
@Stefan-Ethernal Stefan-Ethernal merged commit 0592e11 into develop Apr 6, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/add-receivers-to-sequence-diagrams branch April 6, 2023 07:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stefan-Ethernal @Nemanja0x @goran-ethernal