Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten execution time of E2E tests #1360

Merged
merged 15 commits into from
Apr 10, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Apr 4, 2023

Description

Changelog:

  • Provided a smaller epoch size, compared to the default one in basic consensus tests.
  • Skip TestE2E_Consensus_Sync_WithNonValidators, until we implement proper support for non-validator nodes in E2E framework.
  • Move test helper functions to helpers_test.go.
  • Implement waitForRootchainEpoch helper function, which checks whether target epoch is reached.
  • Merged TestE2E_Bridge_DepositAndWithdrawERC20 and TestE2E_Bridge_MultipleCommitmentsPerEpoch into TestE2E_Bridge_Transfers test (resulted in ~2 mins faster execution).
  • Merged TestE2E_Consensus_Basic_WithNonValidators and TestE2E_Consensus_Sync into TestE2E_Consensus_Basic_WithNonValidators (resulted in ~7 secs faster execution).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal changed the title Provide epoch size to consensus tests Shorten execution time of E2E tests Apr 5, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-548-shorten-e2e-execution-time branch from e24685a to 86027f9 Compare April 6, 2023 21:58
@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 7, 2023
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Apr 7, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 9, 2023 12:26
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-548-shorten-e2e-execution-time branch from a2f764c to 149f738 Compare April 10, 2023 10:27
@Stefan-Ethernal Stefan-Ethernal merged commit f6cc66a into develop Apr 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-548-shorten-e2e-execution-time branch April 10, 2023 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants