EVM-554: Some events might not be received by subscriber #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
subscription.go
,eventStream
when pushing new event to all subscriptions, had aselect case
withdefault
branch, where in case an event could not be added to the update channel, just ignored it. This is not a correct way, since most of the time, we need all the events that we subscribed to.Through this PR, we are now using buffered update channels to mitigate the case where some events might not be passed to the subscriber.
PR also cleans the code from unnecessary go routines, and adds a new UT test.
Changes include
Checklist
Testing