Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-584 Panic -> send on closed channel inside syncer #1364

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Apr 6, 2023

Description

Bug fix for panic that occurs frequently on CI unit tests

panic: send on closed channel

goroutine 1185 [running]:

[github.com/0xPolygon/polygon-edge/syncer.(*syncPeerClient](http://github.com/0xPolygon/polygon-edge/syncer.(*syncPeerClient)).handleStatusUpdate(0xc0026cc500, {0x1086380?, 0xc002a38690}, {0xc0028e9ec0, 0x27})

 /home/runner/work/polygon-edge/polygon-edge/syncer/client.go:219 +0x216

[Network Graph · 0xPolygon/polygon-edge](http://github.com/0xPolygon/polygon-edge/network.(*Topic) ).readLoop.func2()

 /home/runner/work/polygon-edge/polygon-edge/network/gossip.go:106 +0xcb

created by [Network Graph · 0xPolygon/polygon-edge](http://github.com/0xPolygon/polygon-edge/network.(*Topic) ).readLoop

 /home/runner/work/polygon-edge/polygon-edge/network/gossip.go:98 +0x14a

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Apr 6, 2023
@igorcrevar igorcrevar self-assigned this Apr 6, 2023
@igorcrevar igorcrevar force-pushed the feature/EVM-584-panic-send-on-closed-channel branch from 75a8731 to 79be7fa Compare April 6, 2023 15:48
@igorcrevar igorcrevar marked this pull request as ready for review April 6, 2023 16:55
syncer/client.go Show resolved Hide resolved
network/gossip.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really glad this is finally resolved 🚀

@igorcrevar igorcrevar merged commit 3765811 into develop Apr 7, 2023
@igorcrevar igorcrevar deleted the feature/EVM-584-panic-send-on-closed-channel branch April 7, 2023 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants