Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate L2 to L1 e2e tests #1369

Merged
merged 7 commits into from
Apr 10, 2023
Merged

Deprecate L2 to L1 e2e tests #1369

merged 7 commits into from
Apr 10, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Apr 8, 2023 •
edited

Description

This PR deprecates L2 to L1 e2e tests, as they are using dummy test contract and that workflow is already tested using deposit and withdrawal ERC 20 tokens test. It also removes TestL1StateReceiver and adapts TestIntegration_PerformExit to use proper contracts instead of TestL1StateReceiver.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-545-deprecate-test-e-2-e-bridge-l-2-to-l-1-exit-and-test-e-2-e-bridge-l-2-to-l-1-exit-multiple branch from b037a68 to b3595ba Compare April 8, 2023 14:37
@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 9, 2023 12:23
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 9, 2023 12:23
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-545-deprecate-test-e-2-e-bridge-l-2-to-l-1-exit-and-test-e-2-e-bridge-l-2-to-l-1-exit-multiple branch from b3595ba to 3be9008 Compare April 9, 2023 12:25
@Stefan-Ethernal Stefan-Ethernal merged commit f23eb43 into develop Apr 10, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-545-deprecate-test-e-2-e-bridge-l-2-to-l-1-exit-and-test-e-2-e-bridge-l-2-to-l-1-exit-multiple branch April 10, 2023 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@vcastellm vcastellm Awaiting requested review from vcastellm

@igorcrevar igorcrevar Awaiting requested review from igorcrevar

Assignees

@igorcrevar igorcrevar

@Stefan-Ethernal Stefan-Ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Stefan-Ethernal @Nemanja0x @stana-miric @goran-ethernal @igorcrevar