Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-validator nodes in e2e tests #1378

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Apr 12, 2023

Description

This PR supports non-validator nodes in e2e tests.
It only gives the manifest and genesis files those validators that have a ValidatorPrefix from the TestClusterConfig.
Non-validator nodes have a prefix test-non-validator-, which is fixed in tests to separate them from the validator nodes.

This PR also does two things:

  • Merges TestE2E_Consensus_Basic_WithNonValidators and TestE2E_Consensus_Sync_WithNonValidators.
  • Removes --validator-set-size flag from genesis command, since it was not used.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal self-assigned this Apr 12, 2023
@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Apr 12, 2023
@goran-ethernal goran-ethernal requested a review from a team April 12, 2023 07:24
@goran-ethernal goran-ethernal marked this pull request as ready for review April 12, 2023 07:51
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🔥

e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
e2e-polybft/framework/test-cluster.go Show resolved Hide resolved
e2e-polybft/e2e/network_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/consensus_test.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal force-pushed the EVM-547-Improve-e2e-test-framework branch from e796176 to 166eab2 Compare April 12, 2023 08:47
@goran-ethernal goran-ethernal merged commit de2bd8c into develop Apr 12, 2023
@goran-ethernal goran-ethernal deleted the EVM-547-Improve-e2e-test-framework branch April 12, 2023 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants