Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Seal field from the extra data #1379

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Remove unused Seal field from the extra data #1379

merged 3 commits into from
Apr 13, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Apr 12, 2023 •
edited

Description

This PR removes Seal from the extra data since it is not being used (it was just marshaled and unmarshaled back and forth, but without proper value being set).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Removed unused Seal field from the Headers' extra data.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 12, 2023
@Stefan-Ethernal Stefan-Ethernal added the breaking change Functionality that contains breaking changes label Apr 12, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 12, 2023 09:19
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-587-remove-seal-field-from-extra branch from 2dd21cb to f349998 Compare April 12, 2023 09:20
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-587-remove-seal-field-from-extra branch from 573da01 to f2932d2 Compare April 12, 2023 09:54
@Stefan-Ethernal Stefan-Ethernal changed the title Remove unused Seal field from the extra data Remove unused Seal field from the extra data Apr 12, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 12, 2023 11:16
@Stefan-Ethernal Stefan-Ethernal merged commit dd7ec79 into develop Apr 13, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-587-remove-seal-field-from-extra branch April 13, 2023 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
breaking change Functionality that contains breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Stefan-Ethernal @vcastellm @igorcrevar @goran-ethernal