Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide correct state sync event logs filter in TestE2E_Bridge_Transfers #1381

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR provides correct start and ending block numbers when making assertions against the StateSyncResult events count. Prior to this change, those were set arbitrarily, and it could be possible that some of the state sync events being executed by the multiple deposit batches per epoch subtest are captured by the bridge ERC 20 tokens subtest.

An example of such faulty execution can be found here.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Apr 12, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 12, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/logs-filter-bridge-transfer-e2e-test branch from 16f8ed6 to 0a0af6e Compare April 12, 2023 10:08
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 12, 2023 11:16
@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 12, 2023 11:16
@Stefan-Ethernal Stefan-Ethernal merged commit a5aea76 into develop Apr 17, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/logs-filter-bridge-transfer-e2e-test branch April 17, 2023 08:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants