Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_getBlockByHash and eth_getBlockByNumber JSON RPC endpoints should omit Committed field #1383

Merged
merged 6 commits into from
Apr 18, 2023
Merged

eth_getBlockByHash and eth_getBlockByNumber JSON RPC endpoints should omit Committed field #1383

merged 6 commits into from
Apr 18, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Apr 12, 2023 •
edited

Description

Since some fields in polybft in block header ExtraData are not included in the block hash calculation (Committed and Seal fields), they should not be returned by the JsonRPC endpoints (GetBlockByNumber, and GetBlockByHash).

This PR, apart from this, added a new UT.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal self-assigned this Apr 12, 2023
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label Apr 12, 2023
@goran-ethernal goran-ethernal requested a review from a team April 12, 2023 12:58
@goran-ethernal goran-ethernal marked this pull request as ready for review April 12, 2023 13:01
@Stefan-Ethernal Stefan-Ethernal changed the title EVM-588-JsonRPC-endpoints-should-not-return-Committed-field eth_getBlockByHash and eth_getBlockByNumber JSON RPC endpoints should omit Committed field Apr 12, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title eth_getBlockByHash and eth_getBlockByNumber JSON RPC endpoints should omit Committed field eth_getBlockByHash and eth_getBlockByNumber JSON RPC endpoints should omit Committed field Apr 12, 2023
Stefan-Ethernal
Stefan-Ethernal approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

consensus/consensus.go Outdated Show resolved Hide resolved
jsonrpc/eth_endpoint.go Outdated Show resolved Hide resolved
consensus/polybft/extra_test.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal force-pushed the EVM-588-JsonRPC-endpoints-should-not-return-Committed-field branch from bc27867 to 812e039 Compare April 13, 2023 11:19
vcastellm
vcastellm approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goran-ethernal goran-ethernal merged commit e37c9da into develop Apr 18, 2023
@goran-ethernal goran-ethernal deleted the EVM-588-JsonRPC-endpoints-should-not-return-Committed-field branch April 18, 2023 06:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goran-ethernal @vcastellm @igorcrevar @Stefan-Ethernal