Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowlist package refactor and blocklist implementation #1388

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Allowlist package refactor and blocklist implementation #1388

merged 6 commits into from
Apr 20, 2023

Conversation

vcastellm
Copy link
Contributor

Description

This is a refactor of the allowlist package to make it more generic as it's now used for both allowlist and blocklist. It also adds the blocklist implementation.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Allowlist package refactor and blocklist implementation
a5ce44f 
This is a refactor of the allowlist package to make it more generic as it's now used for both allowlist and blocklist. It also adds the blocklist implementation.
@vcastellm vcastellm self-assigned this Apr 14, 2023
@vcastellm vcastellm added the feature New update to Polygon Edge label Apr 14, 2023
@vcastellm vcastellm marked this pull request as ready for review April 14, 2023 20:05
@vcastellm vcastellm requested a review from a team April 14, 2023 20:05
goran-ethernal
goran-ethernal approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Stefan-Ethernal
Stefan-Ethernal reviewed Apr 19, 2023
View reviewed changes
command/genesis/polybft_params.go Show resolved Hide resolved
chain/params.go Outdated Show resolved Hide resolved
state/executor.go Show resolved Hide resolved
e2e-polybft/e2e/acls_test.go Show resolved Hide resolved
state/executor.go Show resolved Hide resolved
e2e-polybft/e2e/acls_test.go Show resolved Hide resolved
@vcastellm vcastellm merged commit fee5ae0 into develop Apr 20, 2023
@vcastellm vcastellm deleted the EVM-592-implement-blocklists branch April 20, 2023 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@vcastellm vcastellm

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcastellm @Stefan-Ethernal @goran-ethernal