Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manifest init step from network bootstrap workflow #1389

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Apr 14, 2023

Description

Changelog:

  • manifest command has been removed in favour of genesis command.
  • premine-validators flag became redundant and is removed. Validators are premined using --premine as it is done with all the other accounts.
  • rootchain init-contracts command is renamed into rootchain deploy, as it is shorter and enough self-explanatory.
  • rootchain deploy instead of manifest, expects genesis file. It's absolute path is provided using --genesis flag.
  • --tracker-start-blocks is removed as the event tracker configuration is now populated automatically into the genesis.json configuration as part of rootchain deployment.
  • sequence of commands is changed: now the genesis command must be run before the rootchain deploy. Exact sequence is documented here.
  • updated README files.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Genesis configuration has changed.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-573-remove-manifest-initialization-from-the-bootstrap-workflow branch 2 times, most recently from 8efb934 to 80b0af7 Compare April 14, 2023 16:44
@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 14, 2023
@Stefan-Ethernal Stefan-Ethernal added feature New update to Polygon Edge breaking change Functionality that contains breaking changes labels Apr 14, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-573-remove-manifest-initialization-from-the-bootstrap-workflow branch from c826371 to 1f42681 Compare April 17, 2023 06:07
@Stefan-Ethernal Stefan-Ethernal changed the title Remove manifest init step from bootstrapping Remove manifest init step from network bootstrap workflow Apr 17, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 17, 2023 07:26
@Stefan-Ethernal Stefan-Ethernal marked this pull request as draft April 17, 2023 07:47
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-573-remove-manifest-initialization-from-the-bootstrap-workflow branch from 6e59cc6 to 8b3efac Compare April 18, 2023 06:31
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 18, 2023 06:40
@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 18, 2023 06:41
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-573-remove-manifest-initialization-from-the-bootstrap-workflow branch 2 times, most recently from 4f06d09 to ae63db2 Compare April 18, 2023 07:11
@Stefan-Ethernal
Copy link
Collaborator Author

cc @gatsbyz, @praetoriansentry, @DannyS03 to follow this PR, as it is going to affect both documentation and deployment procedure.

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-573-remove-manifest-initialization-from-the-bootstrap-workflow branch from ae63db2 to f9801c0 Compare April 18, 2023 08:56
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say goodbye to a not so dear friend. He will not be missed 😛 .

Good job! 💯

@Stefan-Ethernal Stefan-Ethernal merged commit 5feb7f6 into develop Apr 20, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-573-remove-manifest-initialization-from-the-bootstrap-workflow branch April 20, 2023 06:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Functionality that contains breaking changes feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants