Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append ExtraVanity to the beginning of the marshaled ExtraData #1391

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Apr 17, 2023

Description

This PR appends ExtraVanity bytes to the beginning of marshalled extra data bytes slice in the MarshalRLPTo function, instead of doing so for each occasion MarshalRLPTo gets invoked.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 17, 2023
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Apr 17, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 17, 2023 08:05
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 17, 2023 08:05
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-591-add-extra-vanity-on-marshalling-of-extra branch from 6fe59dd to 18e4b90 Compare April 18, 2023 07:11
@Stefan-Ethernal Stefan-Ethernal merged commit f0f2716 into develop Apr 18, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-591-add-extra-vanity-on-marshalling-of-extra branch April 18, 2023 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants