-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new version of go ibft #1392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemanja0x
force-pushed
the
Reference_vp_go_ibft
branch
2 times, most recently
from
April 19, 2023 09:39
45b2c43
to
d0fe526
Compare
Nemanja0x
requested review from
Stefan-Ethernal,
vcastellm,
stana-miric and
goran-ethernal
April 19, 2023 09:57
goran-ethernal
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from small comments, LGTM
Nemanja0x
force-pushed
the
Reference_vp_go_ibft
branch
from
April 20, 2023 04:33
c8b3d8d
to
31864b6
Compare
stana-miric
approved these changes
Apr 20, 2023
Stefan-Ethernal
approved these changes
Apr 20, 2023
Stefan-Ethernal
approved these changes
Apr 20, 2023
Nemanja0x
force-pushed
the
Reference_vp_go_ibft
branch
from
April 20, 2023 12:44
173b639
to
34e6509
Compare
vcastellm
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
igorcrevar
force-pushed
the
Reference_vp_go_ibft
branch
from
May 31, 2023 10:08
34e6509
to
01dca9f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edge implements voting power interface for go-ibft
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Simple
HasQuorum
is left on edge side in order to validate block headers. More complex version ofHasQuorum
has been introduced ongo-ibft
side.