Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM-586]: Paralelize fund transactions sending #1399

Merged
merged 2 commits into from
Apr 18, 2023
Merged

[EVM-586]: Paralelize fund transactions sending #1399

merged 2 commits into from
Apr 18, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Apr 18, 2023 •
edited

Description

This PR executes fund transactions in fund command in parallel for a faster command execution. It also groups all errors from all routines into one so that we can see on command output which transactions failed.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal force-pushed the EVM-586-Paralelize-fund-transactions-sending branch from 7f96ac3 to d910491 Compare April 18, 2023 08:01
@goran-ethernal goran-ethernal self-assigned this Apr 18, 2023
@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Apr 18, 2023
@goran-ethernal goran-ethernal requested a review from a team April 18, 2023 08:04
@goran-ethernal goran-ethernal force-pushed the EVM-586-Paralelize-fund-transactions-sending branch from d910491 to 941a626 Compare April 18, 2023 09:18
@goran-ethernal goran-ethernal marked this pull request as ready for review April 18, 2023 09:19
@goran-ethernal goran-ethernal force-pushed the EVM-586-Paralelize-fund-transactions-sending branch from 941a626 to 617d795 Compare April 18, 2023 11:18
@goran-ethernal goran-ethernal merged commit 1c7d69f into develop Apr 18, 2023
@goran-ethernal goran-ethernal deleted the EVM-586-Paralelize-fund-transactions-sending branch April 18, 2023 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goran-ethernal @vcastellm @igorcrevar @Stefan-Ethernal