Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dht #14

Merged
merged 12 commits into from
Mar 27, 2021
Merged

Feature/dht #14

merged 12 commits into from
Mar 27, 2021

Conversation

Kourin1996
Copy link
Contributor

@Kourin1996 Kourin1996 commented Mar 18, 2021

Description

This PR integrates libp2p/go-libp2p-kad-dht into libp2p function in order to connect new peer automatically.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@Kourin1996 Kourin1996 self-assigned this Mar 18, 2021
@Kourin1996 Kourin1996 changed the title Feature/dht [Draft] Feature/dht Mar 18, 2021
@Kourin1996 Kourin1996 changed the title [Draft] Feature/dht Feature/dht Mar 18, 2021
@Kourin1996 Kourin1996 marked this pull request as ready for review March 24, 2021 08:10
@Kourin1996 Kourin1996 marked this pull request as draft March 25, 2021 09:32
@@ -30,19 +31,26 @@ func (s *Server) setupLibP2P() error {
}
s.addrs = []ma.Multiaddr{addr}

bwc := metrics.NewBandwidthCounter()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's caused by my misunderstanding. Used this as an indicator to get good peer from closest peers

@Kourin1996 Kourin1996 changed the base branch from develop to feature-libp2p-improv March 25, 2021 16:56
@Kourin1996 Kourin1996 marked this pull request as ready for review March 25, 2021 16:56
@ferranbt ferranbt merged commit 9f38ac7 into feature-libp2p-improv Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants