Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve todo comments in json rpc test #1400

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Resolve todo comments in json rpc test #1400

merged 3 commits into from
Apr 24, 2023

Conversation

stana-miric
Copy link
Contributor

This PR resolves TODO comments in the json rpc test. Test in ibft folder is fixed, but since it is planed to remove this folder from the code in the future, tests are also adapted and moved to json rpc test in polybft which contained only one test case. Test case for getting the block by the hash is deleted since this is not a valid parameter as per ethereum documentation (block number should be used)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@stana-miric stana-miric self-assigned this Apr 19, 2023
@Nemanja0x
Copy link
Contributor

This e2e fails: TestE2E_Bridge_Transfers. @Stefan-Ethernal is it flaky?

@Stefan-Ethernal
Copy link
Collaborator

This e2e fails: TestE2E_Bridge_Transfers. @Stefan-Ethernal is it flaky?

It should have been fixed through a5aea76. As far as I can see, this branch does not include this commit. Let's rebase it.

@stana-miric stana-miric force-pushed the EVM-521-resolve-tod-os-in-jsonrpc-test-code branch from fce76fb to 4d71f54 Compare April 20, 2023 08:53
@stana-miric stana-miric merged commit c3a667e into develop Apr 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
@stana-miric stana-miric deleted the EVM-521-resolve-tod-os-in-jsonrpc-test-code branch May 1, 2023 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igorcrevar igorcrevar igorcrevar approved these changes

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@vcastellm vcastellm Awaiting requested review from vcastellm

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

Assignees

@stana-miric stana-miric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stana-miric @Nemanja0x @Stefan-Ethernal @igorcrevar @goran-ethernal