-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize typed atomics #1407
Merged
Stefan-Ethernal
merged 3 commits into
develop
from
EVM-597-utilize-atomic-strongly-typed-values
Apr 25, 2023
Merged
Utilize typed atomics #1407
Stefan-Ethernal
merged 3 commits into
develop
from
EVM-597-utilize-atomic-strongly-typed-values
Apr 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
EVM-597-utilize-atomic-strongly-typed-values
branch
2 times, most recently
from
April 20, 2023 15:47
72d73f4
to
65e4420
Compare
Stefan-Ethernal
force-pushed
the
EVM-597-utilize-atomic-strongly-typed-values
branch
2 times, most recently
from
April 22, 2023 06:41
a30a961
to
17d298b
Compare
Stefan-Ethernal
requested review from
vcastellm,
igorcrevar,
Nemanja0x and
goran-ethernal
April 24, 2023 13:25
Nemanja0x
reviewed
Apr 25, 2023
Nemanja0x
reviewed
Apr 25, 2023
Nemanja0x
reviewed
Apr 25, 2023
Nemanja0x
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the comments. They are not blockers.
igorcrevar
approved these changes
Apr 25, 2023
Stefan-Ethernal
force-pushed
the
EVM-597-utilize-atomic-strongly-typed-values
branch
from
April 25, 2023 09:46
aa0d514
to
09b94ce
Compare
Stefan-Ethernal
force-pushed
the
EVM-597-utilize-atomic-strongly-typed-values
branch
from
April 25, 2023 12:04
09b94ce
to
e583505
Compare
Stefan-Ethernal
deleted the
EVM-597-utilize-atomic-strongly-typed-values
branch
April 25, 2023 12:06
vcastellm
reviewed
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR utilizes typed atomics where appropriate, such as:
atomic.Bool
andatomic.Pointer[T]
, which is possible now when we are running golang 1.19.Changes include
Checklist
Testing