Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize typed atomics #1407

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Apr 20, 2023

Description

This PR utilizes typed atomics where appropriate, such as: atomic.Bool and atomic.Pointer[T], which is possible now when we are running golang 1.19.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-597-utilize-atomic-strongly-typed-values branch 2 times, most recently from 72d73f4 to 65e4420 Compare April 20, 2023 15:47
Base automatically changed from EVM-168-bump-go-version-to-1-19 to develop April 21, 2023 08:56
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-597-utilize-atomic-strongly-typed-values branch 2 times, most recently from a30a961 to 17d298b Compare April 22, 2023 06:41
@Stefan-Ethernal Stefan-Ethernal changed the title Utilize atomic bool Utilize typed atomics Apr 24, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 24, 2023 13:25
@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 24, 2023
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Apr 24, 2023
network/gossip.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Nemanja0x Nemanja0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the comments. They are not blockers.

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-597-utilize-atomic-strongly-typed-values branch from aa0d514 to 09b94ce Compare April 25, 2023 09:46
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-597-utilize-atomic-strongly-typed-values branch from 09b94ce to e583505 Compare April 25, 2023 12:04
@Stefan-Ethernal Stefan-Ethernal merged commit 93ac4d0 into develop Apr 25, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-597-utilize-atomic-strongly-typed-values branch April 25, 2023 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants