[RFC-201/205]: EVM-606-Change stake command #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
added
the
breaking change
goran-ethernal
requested review from
Nemanja0x,
Stefan-Ethernal,
igorcrevar and
vcastellm
goran-ethernal
force-pushed
the
EVM-606-Change-stake-command
branch
from
8219e41
to
15f9260
Compare
goran-ethernal
force-pushed
the
EVM-603-Register-supernet-and-child-chain
branch
from
e747436
to
d007f5a
Compare
goran-ethernal
force-pushed
the
EVM-606-Change-stake-command
branch
from
be53e17
to
a2fae10
Compare
Base automatically changed from
EVM-603-Register-supernet-and-child-chain
to
feat/validator-storage-rework
April 21, 2023 12:29
goran-ethernal
force-pushed
the
EVM-606-Change-stake-command
branch
from
a2fae10
to
211d107
Compare
igorcrevar
reviewed
Apr 21, 2023
Nemanja0x
approved these changes
Apr 21, 2023
Stefan-Ethernal
approved these changes
Apr 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
stakecommand since staking is now done on rootchain (StakeManagercontract).IMPORTANT NOTE: E2E tests will fail, since this is just one in a series of PRs that refactor the staking and validator storage in regards to before mentioned RFCs. E2E tests will be updated in one of the last PRs for the new feature.
Changes include
Breaking changes
stakecommand is changed since staking is now done on rootchain.Checklist
Testing